nit: remove unnecessary call to into_u256() for bn128 add #1239

jtraglia · 2024-03-28T16:51:32Z

This PR removes the intermediate call to into_u256() which appears to be unnecessary. I noticed that ecmul does it like this, and I think it's cleaner this way:

revm/crates/precompile/src/bn128.rs

Lines 157 to 171 in c3107ec

    
           pub fn run_mul(input: &[u8]) -> Result<Bytes, Error> { 
        
               let input = right_pad::<MUL_INPUT_LEN>(input); 
        
               let p = read_point(&input[..64])?; 
        
               // `Fr::from_slice` can only fail when the length is not 32. 
        
               let fr = bn::Fr::from_slice(&input[64..96]).unwrap(); 
        
               let mut out = [0u8; 64]; 
        
               if let Some(mul) = AffineG1::from_jacobian(p * fr) { 
        
                   mul.x().to_big_endian(&mut out[..32]).unwrap(); 
        
                   mul.y().to_big_endian(&mut out[32..]).unwrap(); 
        
               } 
        
               Ok(out.into()) 
        
           }

Also, rename out to output in run_mul for consistency.

rakita

lgtm

…1239) * nit: remove unnecessary call to into_u256() for bn128 add * Rename out to output

commit 787302e Author: Brechtpd <Brechtp.devos@gmail.com> Date: Tue Jun 25 04:29:35 2024 +0200 cleanup diff commit 8dfc65d Author: Brechtpd <Brechtp.devos@gmail.com> Date: Tue Jun 25 04:16:43 2024 +0200 fix warnings commit df642f1 Merge: 9a1e6db a04c7cd Author: Brechtpd <Brechtp.devos@gmail.com> Date: Mon Jun 24 05:22:13 2024 +0200 Merge branch 'v36' into v36-taiko commit a04c7cd Author: rakita <rakita@users.noreply.github.com> Date: Sun May 12 15:16:20 2024 +0300 chore: remove alloydb example as the crate is not published (bluealloy#1398) commit 472de2c Author: rakita <rakita@users.noreply.github.com> Date: Sun May 12 14:55:37 2024 +0300 chore: main CHANGELOG, tag v36 (bluealloy#1397) commit d54bd99 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun May 12 13:43:19 2024 +0200 chore: release (bluealloy#1261) Signed-off-by: GitHub Action <action@github.com> Co-authored-by: GitHub Action <action@github.com> commit d4b0ebc Author: rakita <rakita@users.noreply.github.com> Date: Sun May 12 14:36:13 2024 +0300 feat: Add bytes to Bytecode (bluealloy#1396) * fix(eip2935): Preload blockchash storage address * chore: add bytes fn commit aeefcda Author: rakita <rakita@users.noreply.github.com> Date: Sat May 11 12:03:51 2024 +0200 fix(eip2935): Preload blockchash storage address (bluealloy#1395) commit 7286dc5 Author: Kolby Moroz Liebl <31669092+KolbyML@users.noreply.github.com> Date: Fri May 10 23:57:03 2024 -0600 chore: add Trin to used by list (bluealloy#1393) commit ebbd76a Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Fri May 10 19:16:19 2024 +0200 fix(precompile): blst dangling pointers, cleanup (bluealloy#1391) * fix(precompile): blst dangling pointers, cleanup * chore: correct error message commit a4b466a Author: Alexey Shekhirin <a.shekhirin@gmail.com> Date: Fri May 10 13:13:36 2024 +0100 fix(precompile): inherit Prague precompiles from Cancun (bluealloy#1392) commit 1914696 Author: Alexey Shekhirin <a.shekhirin@gmail.com> Date: Fri May 10 05:44:11 2024 +0100 feat(precompile): Prague - EIP-2537 - BLS12-381 curve operations (bluealloy#1389) * feat(precompile): add Prague hardfork specification * feat(precompile): add Prague hardfork specification * feat(precompile): BLS12-381 * feature-gate blst * run EIP-2537 tests in CI * fix doc comment * fixes after review (arrays to vecs, question mark operators, default inits) * introduce separate variables for mutable blst calls * return value instead of mutating the input argument where possible * replace *mut with *const where mut is not needed commit 15ef150 Author: Dan Cline <6798349+Rjected@users.noreply.github.com> Date: Wed May 8 18:06:09 2024 -0400 chore: bump c-kzg to 1.0.2 (bluealloy#1390) commit ab54cd5 Author: Alexey Shekhirin <a.shekhirin@gmail.com> Date: Wed May 8 15:28:27 2024 +0100 feat(precompile): add Prague hardfork specification (bluealloy#1387) commit 5404a6a Author: Qiwei Yang <yangqiwei97@gmail.com> Date: Wed May 8 19:08:32 2024 +0800 feat: add trace option in `revme evm` (bluealloy#1376) * feat: add trace option * fix: use evm.modify * fix * refactor * Update bins/revme/src/cmd/evmrunner.rs * Update bins/revme/src/cmd/evmrunner.rs commit c1109bd Author: rakita <rakita@users.noreply.github.com> Date: Wed May 8 01:09:15 2024 +0200 chore: refactor lints (bluealloy#1386) * chore: refactor lints * rustdoc lints * fix doc link commit f24bf3b Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Tue May 7 17:41:11 2024 +0200 feat: add a hook to execute individual frames (bluealloy#1369) * feat: add a hook to optionally execute individual frames * Move Host to Context and modify execute frame handle * return error form execute frame handle, nits commit 24f2db3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 7 13:55:26 2024 +0200 chore(deps): bump reqwest from 0.12.2 to 0.12.4 (bluealloy#1384) Bumps [reqwest](https://github.com/seanmonstar/reqwest) from 0.12.2 to 0.12.4. - [Release notes](https://github.com/seanmonstar/reqwest/releases) - [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md) - [Commits](seanmonstar/reqwest@v0.12.2...v0.12.4) --- updated-dependencies: - dependency-name: reqwest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 37e76b7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 7 13:13:04 2024 +0200 chore(deps): bump serde from 1.0.197 to 1.0.200 (bluealloy#1385) Bumps [serde](https://github.com/serde-rs/serde) from 1.0.197 to 1.0.200. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.197...v1.0.200) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 432852c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 7 13:12:55 2024 +0200 chore(deps): bump thiserror from 1.0.58 to 1.0.59 (bluealloy#1383) Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.58 to 1.0.59. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.58...1.0.59) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7f19b98 Author: Yash Atreya <44857776+yash-atreya@users.noreply.github.com> Date: Sat May 4 14:02:36 2024 -0700 chore: add blob_count and max_blobs to `TooManyBlobs` err enum (bluealloy#1375) * add: essential info to `TooManyBlobs` err enum * fix clippy * nit: with names * fix commit 8f5be0e Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sat May 4 22:51:39 2024 +0200 chore(revme): increment statetest bar *after* running the test (bluealloy#1377) commit f778a5d Author: halo3mic <46010359+halo3mic@users.noreply.github.com> Date: Sat May 4 22:51:15 2024 +0200 bump alloy & specify dep rev (bluealloy#1380) * bump alloy & specify dep rev * satisfy fmt check commit f0cfe77 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sat May 4 22:50:26 2024 +0200 chore: remove unused file (bluealloy#1379) commit 569760d Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Fri May 3 13:42:36 2024 +0200 perf(interpreter): branch less in as_usize_or_fail (bluealloy#1374) * perf(interpreter): branch less in as_usize_or_fail * chore: clippy commit 99e177d Author: rakita <rakita@users.noreply.github.com> Date: Thu May 2 16:27:01 2024 +0400 chore(ci): bump action/deploy (bluealloy#1372) commit 12062b0 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Thu May 2 14:10:20 2024 +0200 chore: re-use num_words in gas::cost_per_word (bluealloy#1371) commit 3e089f3 Author: Oliver Nordbjerg <onbjerg@users.noreply.github.com> Date: Thu May 2 09:13:38 2024 +0200 feat: implement EIP-2935 (bluealloy#1354) * feat: add eip-2935 constants * feat: impl EIP-2935 `BLOCKHASH` * fix: early return in prague * chore: fmt * refactor: `sload!` macro * chore: rm unused import * chore: rename consts * fix: typo from merge commit aceb093 Author: rakita <rakita@users.noreply.github.com> Date: Wed May 1 12:03:36 2024 +0400 feat(Handler): Add ClearHandle (bluealloy#1368) * fix(revme): Print one json outcome in statetest * feat(Handler): Add ClearHandle * nits * clippy commit 67c13f3 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Wed May 1 08:47:22 2024 +0200 feat: parse opcodes from strings (bluealloy#1358) commit a2279f2 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon Apr 29 15:49:53 2024 +0200 perf(interpreter): rewrite gas accounting for memory expansion (bluealloy#1361) * feat(interpreter): add helpers for spending all gas * perf(interpreter): rewrite gas accounting for memory expansion * chore: do not inline * chore: restore Cargo.toml commit 3f5bb76 Author: Paweł Urbanek <contact@pawelurbanek.com> Date: Mon Apr 29 14:54:35 2024 +0200 feat: Add uniswap V2 WETH-USDC swap example (bluealloy#1353) * Add uniswap V2 WETH-USDC swap example * Use alloy primitives * Use revm primitives * Use alloydb * Use only necessary pair slots * typo * Simplify error handling * Improve numbers decoding * Dont use panic for errors * Remove unused feature * Use alloydb instead of manually fetching data commit 1f44e4c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 29 13:39:54 2024 +0200 chore(deps): bump hashbrown from 0.14.3 to 0.14.5 (bluealloy#1365) Bumps [hashbrown](https://github.com/rust-lang/hashbrown) from 0.14.3 to 0.14.5. - [Changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md) - [Commits](rust-lang/hashbrown@v0.14.3...v0.14.5) --- updated-dependencies: - dependency-name: hashbrown dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ac3fa4f Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon Apr 29 13:39:30 2024 +0200 perf: remove bounds check in DUP, SWAP/EXCHANGE (bluealloy#1346) * perf: remove bounds check in DUP * perf: use `mem::swap` in stack swap/exchange * docs: is_static doc driveby * chore: use swap_nonoverlapping * chore: restore Cargo.toml commit f59ce8c Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon Apr 29 13:36:10 2024 +0200 feat(interpreter): add helpers for spending all gas (bluealloy#1360) commit 215a4c4 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon Apr 29 13:35:45 2024 +0200 fix: return the correct error in resize_memory (bluealloy#1359) commit 9ec2248 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 29 13:16:37 2024 +0200 chore(deps): bump aurora-engine-modexp from 1.0.0 to 1.1.0 (bluealloy#1339) Bumps [aurora-engine-modexp](https://github.com/aurora-is-near/aurora-engine) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/aurora-is-near/aurora-engine/releases) - [Changelog](https://github.com/aurora-is-near/aurora-engine/blob/develop/CHANGES.md) - [Commits](aurora-is-near/aurora-engine@1.0.0...1.1.0) --- updated-dependencies: - dependency-name: aurora-engine-modexp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9165a4a Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon Apr 29 12:54:55 2024 +0200 chore: don't clone bytes in `Bytecode::bytes` (bluealloy#1344) commit 16b3f21 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon Apr 29 12:49:55 2024 +0200 refactor: shrink OpCodeInfo and add more methods (bluealloy#1307) * refactor: shrink OpCodeInfo and add more methods * review * Update crates/interpreter/src/opcode.rs * Update crates/interpreter/src/opcode.rs commit 1ca3d39 Author: rakita <rakita@users.noreply.github.com> Date: Sun Apr 21 11:32:31 2024 +0400 fix(revme): Print one json outcome in statetest (bluealloy#1347) commit 76e22ba Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sun Apr 21 09:32:06 2024 +0200 feat: add helper methods to CallInputs (bluealloy#1345) commit bcdc652 Author: Thomas Coratger <60488569+tcoratger@users.noreply.github.com> Date: Sun Apr 21 09:21:59 2024 +0200 Implement `with_chain_id` for `CfgEnv` (bluealloy#1327) * Implement with_chain_id for CfgEnv * cargo fmt * fix comments commit e987d2b Author: Iaroslav Mazur <iaroslav.mazur@proton.me> Date: Fri Apr 19 23:46:09 2024 +0300 chore: update GitHub Actions to Node 20 (bluealloy#1338) commit 43199dd Author: Matthias Seitz <matthias.seitz@outlook.de> Date: Fri Apr 19 22:42:20 2024 +0200 chore: weekly dependabot (bluealloy#1325) commit 41beddf Author: Iaroslav Mazur <iaroslav.mazur@proton.me> Date: Fri Apr 19 23:41:48 2024 +0300 docs: fix the Instruction Table link (bluealloy#1337) commit 688c36c Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Tue Apr 16 22:02:45 2024 +0200 chore(interpreter): rename some macros (bluealloy#1304) commit aec666a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Apr 16 22:01:47 2024 +0200 chore(deps): bump anyhow from 1.0.81 to 1.0.82 (bluealloy#1293) Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.81 to 1.0.82. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.81...1.0.82) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9cfd144 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Tue Apr 16 21:27:22 2024 +0200 perf(interpreter): remove EOF branch in CODE{SIZE,COPY} (bluealloy#1308) commit cc1b9f7 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Tue Apr 16 21:22:39 2024 +0200 chore: fix some warnings (bluealloy#1305) commit 72356e3 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Tue Apr 16 21:22:16 2024 +0200 chore(interpreter): rename wrapping_* opcodes (bluealloy#1306) commit f4f4745 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sat Apr 13 14:13:15 2024 +0200 fix: correct some stack IO (bluealloy#1302) * fix: correct some stack IO * chore: remove dead code commit 5d25c4d Author: Mihir Wadekar <mwadekar2000@gmail.com> Date: Sat Apr 13 05:12:07 2024 -0700 fix: Drops check for .json when testing a single file (bluealloy#1301) commit 7957c02 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sat Apr 13 14:11:45 2024 +0200 feat: add `Bytecode::original_bytecode_slice` to match `BytecodeLocked` (bluealloy#1286) commit fa9e127 Author: n0b0dy <n0b0dyCN@users.noreply.github.com> Date: Sat Apr 13 20:10:37 2024 +0800 feat(revm): make `FrameOrResult` serializable (bluealloy#1282) * feat(revm): make `FrameOrResult` serializable This commit make all structs under `FrameOrResult` serializable, which is useful when trying to save execution state inside an inspector during transaction execution. The modified structs include: * revm: `FrameOrResult`, `FrameResult`, `Frame`, `FrameData`, `CallFrame`, `CreateFrame`, `JournalCheckpoint` * interpreter: `BytecodeLocked`, `Contract`, `Gas`, `CreateOutcome`, `CallOutcome`, `Interpreter` * style(interpreter): make clippy happy * fix(interpreter): fix missing conflict * style(interpreter): make clippy happy commit e0f72a0 Author: Wodann <Wodann@users.noreply.github.com> Date: Sat Apr 13 07:07:59 2024 -0500 feat: add flag to force hashbrown usage (bluealloy#1284) * feat: add flag to force hashbrown usage * misc: propagate hashbrown feature flag commit cfc4511 Author: Jonathan Becker <jonathan@jbecker.dev> Date: Tue Apr 9 20:03:21 2024 -0400 docs(inspectors): change `serde` to `serde-json` for `TracerEip3155` (bluealloy#1285) commit cf96ce8 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Wed Apr 10 01:54:56 2024 +0200 feat(revme): add --keep-going to statetest command (bluealloy#1277) commit b4a87a4 Author: rakita <rakita@users.noreply.github.com> Date: Wed Apr 10 01:48:18 2024 +0200 feat: EOF (Ethereum Object Format) (bluealloy#1143) * eof * feat(EOF): Header decoder * EofBody decode * disable eof deprecated opcodes * add eof instructions * temp tests * rjump instructions * eof rjump with tests * EOF bytecode * callf, retf, jumpf * tests for callf,retf,jumpf * small rename * add dataload, dataloadn and datacopy opcodes * refactor calls * blueprint for creates * eof create inputs * some wip * add eofcreate structs and exccall flow * wip eofcreate code flow and handlers * fix tests * eof creates * refactor eofcreate a little * some work on extcall * feat: refactor simplify CallInput, eof extcalls * feat: restructure OpCode and add stack input/output num * add flags for stack_io and not_eof * wip eof verification * wip validation * EOF Bytecode validity * insturction and jump validation seems good * merged eof validate function * EOP test runner, fex fixes * RETURNDATALOAD, fix call bugs, refactor gas warm/cold calc * debug session, rjumpv imm fix * fixing validation bugs, bytecode decoder for EOF in revme * pass most of validation tests * bounds check moved to decode * Fix merge compilation, fmt * TXCREATE work * remove training wheels, panic on eof * test fix and std * std * fix test * fix valgrind * fix tests * clippy * removed checked logic * small change * no std revm-test * check pending TODOs * build check no_std * doc * chore: move some files. cleanup comments * fix fmt,clippy and compile error commit 1edfeb6 Author: Pana <pana.wang@outlook.com> Date: Mon Apr 8 20:56:55 2024 +0800 Update documentation (bluealloy#1275) * fix examples->generate_block_traces reuse TracerEip3155.gas_inspector issue * fmt code * clear the eip3155 tracer state so that it can be used in next transaction * print summary and clean state when create_end * update documentation * fix left nits * add cancun upgrade block number * remove outdated doc * remove outdated doc * remove empty file * TS is unit used to trigger the hardork --------- Co-authored-by: rakita <rakita@users.noreply.github.com> commit d06f5d0 Author: Wodann <Wodann@users.noreply.github.com> Date: Mon Apr 8 07:17:50 2024 -0500 feat: pass rand feature to alloy_primitives (bluealloy#1276) commit 11e819c Author: Akash S M <akashsm@ce.iitr.ac.in> Date: Sun Apr 7 19:10:17 2024 +0530 Add the modifies_memory macro (bluealloy#1270) * feat: add modifies_memory macro * refactor commit c1eb0e6 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sun Apr 7 15:39:20 2024 +0200 perf(interpreter): use `pop_top!` where possible (bluealloy#1267) commit c961887 Author: rakita <rakita@users.noreply.github.com> Date: Sun Apr 7 15:28:34 2024 +0200 chore: revert snailtracer without microbench (bluealloy#1259) * check without microbench * cleanup commit d3db49d Author: rakita <rakita@users.noreply.github.com> Date: Sun Apr 7 06:01:08 2024 +0200 chore(ci): use more stable rust toolchain plugin (bluealloy#1269) commit eee0541 Author: Akash S M <akashsm@ce.iitr.ac.in> Date: Sat Apr 6 23:48:52 2024 +0530 minor typo fix in docs (bluealloy#1266) * fix typo * fix typo commit af56651 Author: evalir <hi@enriqueortiz.dev> Date: Fri Apr 5 23:29:56 2024 +0200 feat(`db`): Introduce `alloydb` (bluealloy#1257) * feat: alloydb * chore: turn on needed deps for test * derive * correct address * chore: remove arc * feat: actually make Transport and Network generic to accept any transport or network * chore: condense markers into one, more idiomatic commit 5e730a6 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Fri Apr 5 23:29:32 2024 +0200 chore: add and use EvmContext::take_error (bluealloy#1264) commit 4d64bbc Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Fri Apr 5 16:00:03 2024 +0200 feat(interpreter): derive Eq for InterpreterAction (bluealloy#1262) commit 96dda38 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Wed Apr 3 21:51:29 2024 +0200 feat(interpreter): remove SPEC generic from gas calculation functions (bluealloy#1243) * feat(interpreter): remove SPEC generic from gas calculation functions * feat(interpreter): make most gas cost calculation functions `const` * set_final_refund * unused * fix: optimism * chore: use `is_london: bool` instead of `SpecId` in `Gas::set_final_refund` commit 5d5c5f1 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Apr 3 21:46:28 2024 +0200 chore(deps): bump secp256k1 from 0.28.2 to 0.29.0 (bluealloy#1260) Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from 0.28.2 to 0.29.0. - [Changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md) - [Commits](rust-bitcoin/rust-secp256k1@secp256k1-0.28.2...secp256k1-0.29.0) --- updated-dependencies: - dependency-name: secp256k1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8af9531 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Wed Apr 3 10:07:03 2024 +0200 feat(interpreter): test Host object-safety, allow `dyn Host` in instructions (bluealloy#1245) commit 223f6cd Author: rakita <rakita@users.noreply.github.com> Date: Tue Apr 2 22:08:49 2024 +0200 chore: fix publish revm-precompile (bluealloy#1258) commit 1640b8f Author: rakita <rakita@users.noreply.github.com> Date: Tue Apr 2 21:30:23 2024 +0200 chore: simple publish script (bluealloy#1256) commit 2e2babc Author: rakita <rakita@users.noreply.github.com> Date: Tue Apr 2 21:17:11 2024 +0200 chore: main CHANGELOG, tag v35 (bluealloy#1255) commit 4a8c0bf Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 2 21:05:20 2024 +0200 chore: release (bluealloy#1231) Signed-off-by: GitHub Action <action@github.com> Co-authored-by: GitHub Action <action@github.com> commit 52f1f01 Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Tue Apr 2 13:55:46 2024 -0500 feat: add tests for shift instructions (bluealloy#1254) * feat: add tests for shift instructions * Use LatestSpec instead of CancunSpec * Run cargo fmt * Use parans instead of brackets * Simplify host/interpreter initialization * Remove unused imports * Remove test case comments * Use U256 types commit c3f0503 Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Tue Apr 2 04:53:55 2024 -0500 nit: use uint macro & fix various small things (bluealloy#1253) * nit: Use uint macro & fix various small things * Move MAX_POSITIVE_VALUE back to tests commit b3220c6 Author: Matthias Seitz <matthias.seitz@outlook.de> Date: Mon Apr 1 02:37:23 2024 +0200 chore(deps): bump other alloy deps 0.7.0 (bluealloy#1252) commit d9d1a64 Author: Matthias Seitz <matthias.seitz@outlook.de> Date: Sun Mar 31 13:43:59 2024 +0200 chore(deps): bump alloy 0.7.0 (bluealloy#1250) commit 9079099 Author: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sun Mar 31 12:54:25 2024 +0200 feat: derive serde for OpCode, improve implementations (bluealloy#1215) commit b1ec4eb Author: Pana <pana.wang@outlook.com> Date: Sun Mar 31 18:52:35 2024 +0800 fix(TracerEip3155): clear Inspector data after transaction. (bluealloy#1230) * fix examples->generate_block_traces reuse TracerEip3155.gas_inspector issue * fmt code * clear the eip3155 tracer state so that it can be used in next transaction * print summary and clean state when create_end * update documentation * fix left nits commit 57825ff Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Sat Mar 30 05:19:52 2024 -0500 nit: move div by zero check from smod to i256_mod (bluealloy#1248) commit a201a2d Author: A_A <21040751+Otto-AA@users.noreply.github.com> Date: Fri Mar 29 20:32:35 2024 +0100 feat: TracerEip3155 optionally traces memory (bluealloy#1234) * feat: TracerEip3155 optionally traces memory BREAKING CHANGE: the TracerEIP3155 constructor takes an additional "include_memory" flag * perf: use hex::encode_prefixed for TracerEip3155 * refactor: use builder pattern for TracerEip3155 BREAKING CHANGE: update constructor syntax for TracerEip3155 * refactor: use String for TracerEip3155 memory commit e0791cd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Mar 29 12:10:03 2024 +0100 chore(deps): bump tokio from 1.36.0 to 1.37.0 (bluealloy#1244) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.36.0 to 1.37.0. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.36.0...tokio-1.37.0) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f5e56fb Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Fri Mar 29 06:09:54 2024 -0500 fix: update/enable bn128 tests (bluealloy#1242) commit b6bda4c Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Fri Mar 29 06:08:40 2024 -0500 docs: link to point evaluation documentation (bluealloy#1241) commit 81b65dd Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Thu Mar 28 12:14:22 2024 -0500 nit: remove unnecessary call to into_u256() for bn128 add (bluealloy#1239) * nit: remove unnecessary call to into_u256() for bn128 add * Rename out to output commit 020c6ff Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Thu Mar 28 11:53:33 2024 -0500 fix: use correct bn128 mul input length (bluealloy#1238) commit a114438 Author: rakita <rakita@users.noreply.github.com> Date: Thu Mar 28 17:52:38 2024 +0100 fix(GasInspector): calculate correct remaining gas after call return (bluealloy#1236) commit c3107ec Author: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Thu Mar 28 06:25:31 2024 -0500 fix: use correct rand package for thread_rng (bluealloy#1233)

jtraglia added 2 commits March 28, 2024 11:46

nit: remove unnecessary call to into_u256() for bn128 add

635e1c3

Rename out to output

8b599c7

rakita approved these changes Mar 28, 2024

View reviewed changes

rakita merged commit 81b65dd into bluealloy:main Mar 28, 2024
25 checks passed

jtraglia deleted the remove-into_u256 branch March 28, 2024 17:18

github-actions bot mentioned this pull request Mar 28, 2024

chore: release #1231

Merged

fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024

nit: remove unnecessary call to into_u256() for bn128 add (bluealloy#…

65268d1

…1239) * nit: remove unnecessary call to into_u256() for bn128 add * Rename out to output

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nit: remove unnecessary call to into_u256() for bn128 add #1239

nit: remove unnecessary call to into_u256() for bn128 add #1239

jtraglia commented Mar 28, 2024

rakita left a comment

	pub fn run_mul(input: &[u8]) -> Result<Bytes, Error> {
	let input = right_pad::<MUL_INPUT_LEN>(input);

	let p = read_point(&input[..64])?;

	// `Fr::from_slice` can only fail when the length is not 32.
	let fr = bn::Fr::from_slice(&input[64..96]).unwrap();

	let mut out = [0u8; 64];
	if let Some(mul) = AffineG1::from_jacobian(p * fr) {
	mul.x().to_big_endian(&mut out[..32]).unwrap();
	mul.y().to_big_endian(&mut out[32..]).unwrap();
	}
	Ok(out.into())
	}

nit: remove unnecessary call to into_u256() for bn128 add #1239

nit: remove unnecessary call to into_u256() for bn128 add #1239

Conversation

jtraglia commented Mar 28, 2024

rakita left a comment

Choose a reason for hiding this comment